Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to the latest version of adaptive expressions and enable suggestions for type checking functions #2607

Merged
merged 2 commits into from
Apr 10, 2020
+25 −1
Merged

fix: Switch to the latest version of adaptive expressions and enable suggestions for type checking functions #2607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e92626
fix expression version and suggestions
cosmicshuai Apr 10, 2020
27ce766
Merge branch 'master' into shuwan/updateLGPackages
cwhitten Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Composer/packages/tools/language-servers/language-generation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
},
"dependencies": {
"@bfc/indexers": "*",
"adaptive-expressions": "^4.8.0-preview-110700",
"botbuilder-lg": "^4.9.0-preview-117748",
"request-light": "^0.2.2",
"vscode-languageserver": "^5.3.0-next"
Expand Down
25 changes: 25 additions & 0 deletions Composer/packages/tools/language-servers/language-generation/src/builtinFunctionsMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,31 @@ export const buildInfunctionsMap: Map<string, FunctionEntity> = new Map<string,
),
],

//type checing functions
[
'isInteger',
new FunctionEntity(['input: any'], ReturnType.Boolean, 'determine whether a given input is an integer number.'),
],
[
'isFloat',
new FunctionEntity(['input: any'], ReturnType.Boolean, 'determine whether a given input is a float point number.'),
],
[
'isBoolean',
new FunctionEntity(['input: any'], ReturnType.Boolean, 'determine whether a given input is a boolean.'),
],
['isArray', new FunctionEntity(['input: any'], ReturnType.Boolean, 'determine whether a given input is an array.')],
['isObject', new FunctionEntity(['input: any'], ReturnType.Boolean, 'determine whether a given input is an object.')],
[
'isDateTime',
new FunctionEntity(
['input: any'],
ReturnType.Boolean,
'determine whether a given input is a UTC ISO format timestamp.'
),
],
['isString', new FunctionEntity(['input: any'], ReturnType.Boolean, 'determine whether a given input is a string.')],

// Functions injected from LG library
// https://github.com/microsoft/BotBuilder-Samples/blob/master/experimental/language-generation/docs/Functions-injected-from-LG.md
[
Expand Down