fix: various form bugs #2592
Merged
fix: various form bugs #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
reviewed
Apr 10, 2020
Composer/packages/extensions/adaptive-form/src/components/fields/OpenObjectField/ObjectItem.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Apr 10, 2020
Composer/packages/extensions/adaptive-form/src/components/fields/OpenObjectField/ObjectItem.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/adaptive-form/src/components/fields/OpenObjectField/ObjectItem.tsx
Show resolved
Hide resolved
srinaath
reviewed
Apr 10, 2020
Composer/packages/ui-plugins/expressions/src/ExpressionField.tsx
Outdated
Show resolved
Hide resolved
cwhitten
approved these changes
Apr 10, 2020
This was referenced Apr 10, 2020
7 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* force number field to display blank value when no value set * differentiate number and integer * do not unset value if selecting the same type * remove unecessary fragment * make sure scroll bar appears correctly for form * fix problem editing open object values * remove dead styles * fix ability to edit form title * add missing aria labels * send focus to key field after adding new value * translate error messages * do not default value to string * use simplified margin syntax * extract getValueType into utils Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few issues in the form filed recently.
Task Item
closes #2575
closes #2566
closes #2562
closes #2535