feat: Add runtime settings page and eject #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged master apr 13 |
add actual file copy mechanism
…nto benbrown/2470
…nto benbrown/2470
…nto benbrown/2470
update the readme file included in the runtime
…nto benbrown/2470
…nto benbrown/2470
…nto benbrown/2470
…nto benbrown/2470
…nto benbrown/2470
…nto benbrown/2470
…nto benbrown/2470
…poser into benbrown/2470
a-b-r-o-w-n
requested changes
Apr 21, 2020
Composer/packages/client/src/pages/setting/runtime-settings/ejectModal.tsx
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/runtime-settings/ejectModal.tsx
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/runtime-settings/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/runtime-settings/index.tsx
Outdated
Show resolved
Hide resolved
|
all comments addressed. Thanks a lot @a-b-r-o-w-n |
a-b-r-o-w-n
approved these changes
Apr 23, 2020
7 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add new runtime settings page * add popup modal for pickign runtime * add ability for plugins to specify a runtime template * add sample runtime to localPublish add actual file copy mechanism * handle success and failure of runtime injection * respect enableCustomRuntime * pull real runtime code * eject real code update the readme file included in the runtime * change the path of the declarative assets relative to the runtime * update code copying to reflect new asset locations * cleanup * allow parameters to be included in start command * update readme with new info about additional plugin APIs * change schema of settings * little bit more error correction * fix issue with field binding * fix form behaviors * address comments from andy Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new settings page that controls the settings related to using a custom runtime.
If a user enables the custom runtime option, they can specify the path to the runtime and the start command and parameters.
This will cause the localPublish plugin to use that path and start command instead of the default one.
Clicking the link to get a copy of the runtime code will cause a new copy of the runtime template (same one used by localPublish) to be copied into the bot project. It will also auto-configure the path and start command.
This PR includes:
Task Item
Closes #2470
Closes #2450
Screenshots
This GIF shows the settings page in operation, the eject process, and several possible error states related to using this setting with the start bot button.