Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: change button to icon in FieldLabel.tsx #2551

Merged
merged 6 commits into from
Apr 8, 2020
Merged

a11y: change button to icon in FieldLabel.tsx #2551

merged 6 commits into from
Apr 8, 2020

Conversation

beyackle
Copy link
Contributor

@beyackle beyackle commented Apr 7, 2020

Description

Replaces the icon button in FieldLabel with an ordinary Icon (and makes sure it's still in screen-reader tabbable order).

Task Item

Closes #2115

Screenshots

Also just a minor adjustment so the focus rectangle looks better.

image

@github-actions
Copy link

github-actions bot commented Apr 7, 2020

Coverage Status

Coverage remained the same at 40.463% when pulling 79e936f on beyackle/formTooltipIcon into bc511ba on master.

@cwhitten
Copy link
Member

cwhitten commented Apr 7, 2020 •
edited
Loading

@beyackle can we bump the icon/focus indication over a few pixels to not overlap on top of the label?

@beyackle
Copy link
Contributor Author

beyackle commented Apr 7, 2020

@cwhitten Will do.

@beyackle
Copy link
Contributor Author

beyackle commented Apr 7, 2020

Updated spacing.

image

a-b-r-o-w-n
a-b-r-o-w-n approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callout caret is slightly off-center. Is there a way to align it in the middle? I see this in master too, so if you want to go ahead and merge, that's ok with me.

@cwhitten cwhitten merged commit 98624cc into master Apr 8, 2020
@cwhitten cwhitten deleted the beyackle/formTooltipIcon branch April 8, 2020 03:51
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@beyackle @cwhitten @a-b-r-o-w-n
a11y: change button to icon in FieldLabel.tsx (microsoft#2551)
6f9adb1 
* Update FieldLabel.tsx

* Update FieldLabel.tsx

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beyackle @cwhitten @a-b-r-o-w-n