a11y: fix NavItem a11y issues #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
previously requested changes
Apr 6, 2020
|
Fixed the E2E tests, and adjusted the font size back to normal: |
|
The other thing I notice is that the active element is offset with respect to the other links.
|
|
|
|
I changed the margin when active |
|
Thanks for taking care of that - this slipped my mind while I was working on the labels thing. |
|
That E2E failure is the exact same one I'm seeing on my other PR, too. The "SaveAs" task, which I haven't touched and which I was able to manually step through and it seems like it should work. |
|
I pulled this and tested locally. LGTM. Not sure about the failing test. @cwhitten is this related to the test failures you mentioned in our 1:1 yesterday? |
|
Yea @a-b-r-o-w-n is fixing that |
corinagum
approved these changes
Apr 8, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix NavItem a11y issues * Update styles.ts * fix NavItem a11y issues * Update styles.ts * Update styles.ts * move data-testid * Fix selected offset in left nav Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was much easier to fix the problems in NavItem than to rip it out and replace it with a Nav (thanks to the still-unaddressed issues in Nav with SPA react-router-style links), so after fixing up the CSS and removing the unneeded button component, this was the result.
Task Item
Closes #2025
Closes #2040
Screenshots