fix: fix toggle not work in settings page #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested changes
Apr 2, 2020
Composer/packages/client/src/pages/setting/dialog-settings/index.tsx
Outdated
Show resolved
Hide resolved
|
Actually, do we really need this feature? can we just remove this feature @a-b-r-o-w-n @cwhitten? like in Azure Portal to config a DB or something or LUIS key, they don't really hide the keys through some toggle control, i guess their treatment must meet compliance, so? |
|
I think this was requested by the ABS-H team, I'll defer to @cwhitten on what to do. |
|
@a-b-r-o-w-n @boydc2014 I think we can remove this feature too. I am not sure whether it still need after decoupled with absh publish. |
|
@cwhitten any thoughts? |
|
@VanyLaw lets just remove the view complexity toggling this altogether for the time being. |
a-b-r-o-w-n
requested changes
Apr 6, 2020
|
OK, I will remove the toggle and obfuscate feature. |
a-b-r-o-w-n
reviewed
Apr 7, 2020
Composer/packages/client/src/pages/setting/dialog-settings/index.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
reviewed
Apr 7, 2020
a-b-r-o-w-n
approved these changes
Apr 8, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix toggle on change * add debounce in setting * change jsonEditor about obfuscate * remove toggle in setting page * remove obfuscate feature in jsonEditor * fix settings page height * memory the onChange function * change useMemo Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove the toggle feature in settings page
Task Item
close #2444
Screenshots