Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue rendering delete properties action #2460

Merged
merged 4 commits into from
Apr 2, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

This happened because I was recursing on object types with properties defined which collided with a schema property named properties. This is unnecessary now as I don't need to recurse the schema.

Task Item

fixes #2458

Screenshots

image

@github-actions
Copy link

github-actions bot commented Apr 2, 2020

Coverage Status

Coverage increased (+0.1%) to 39.663% when pulling 2c9bff9 on a-b-r-o-w-n:fix/delete-properties into be2d064 on microsoft:master.

@cwhitten cwhitten merged commit e14850e into microsoft:master Apr 2, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix/delete-properties branch April 17, 2020 17:17
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix issues rendering delete properties actions

* no longer recurse on schema

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants