Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lg resolver with locale #2362

Merged
merged 3 commits into from
Mar 26, 2020
Merged

fix: lg resolver with locale #2362

merged 3 commits into from
Mar 26, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Mar 25, 2020 •
edited
Loading

Description

Enable resolve file with or without locale.

   *  for example:
   *  in todosample.en-us.lg:
   *   [import](common.lg)
   *
   *  would resolve to common.en-us.lg || common.lg
   *

Task Item

close #2361

Screenshots

a-b-r-o-w-n
a-b-r-o-w-n requested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like roughly the same code in each of these places. Can we extract out to a shared utility? It probably belongs in the the shared package.

@zhixzhan
Copy link
Contributor Author

This looks like roughly the same code in each of these places. Can we extract out to a shared utility? It probably belongs in the the shared package.

Great idea, I implement a function called importResolverGenerator in shared lib, by feeding it different resources, now client/server, lg/lu all could reuse it.

@zhixzhan zhixzhan requested a review from a-b-r-o-w-n March 26, 2020 04:33
@a-b-r-o-w-n a-b-r-o-w-n merged commit c7ca778 into microsoft:master Mar 26, 2020
@zhixzhan zhixzhan deleted the lg-resolve-fix branch March 31, 2020 02:24
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan
fix: lg resolver with locale (microsoft#2362)
dd373cf 
* fix lg resolver with locale

* generate importResolver in shared lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhixzhan @a-b-r-o-w-n