Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file serialization regressions #2360

Merged
merged 3 commits into from
Mar 25, 2020
Merged

fix: file serialization regressions #2360

merged 3 commits into from
Mar 25, 2020

Conversation

zhixzhan
Copy link
Contributor

Description

when create or save as bot, rename entry dialog/lg/lu

Task Item

refs #2357

  1. serialization has a couple minor issues:
    when a template is selected for creation, the main/entry dialog is the name of the template, when it should be the name the user gave for the bot.

Screenshots

@cwhitten cwhitten merged commit 79973c0 into microsoft:master Mar 25, 2020
@cwhitten cwhitten mentioned this pull request Mar 25, 2020
Closed
@zhixzhan zhixzhan deleted the bugfix branch March 31, 2020 02:24
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @cwhitten
fix: file serialization regressions (microsoft#2360)
7e55113 
* when create bot, serialize entry dialog/lg/lu

* update test

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhixzhan @cwhitten