Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: resolve issues in Notifications page #2343

Merged
merged 4 commits into from
Mar 23, 2020
Merged

a11y: resolve issues in Notifications page #2343

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f3c420
resolve issues in Notifications page
beyackle Mar 23, 2020
8ff7942
Update index.tsx
beyackle Mar 23, 2020
b5cf3b2
Update index.js
beyackle Mar 23, 2020
28b376d
Merge branch 'master' into beyackle/notificationPageA11y
a-b-r-o-w-n Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/src/components/Header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const Header = props => {
<img
style={{ marginLeft: '9px', marginTop: '6px' }}
alt={formatMessage('Composer Logo')}
ariaLabel={formatMessage('Composer Logo')}
aria-label={formatMessage('Composer Logo')}
src={composerIcon}
/>
<span css={title}>{formatMessage('Bot Framework Composer')}</span>
Expand Down
2 changes: 2 additions & 0 deletions Composer/packages/client/src/components/Pagination/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { jsx } from '@emotion/core';
import { DefaultButton } from 'office-ui-fabric-react/lib/Button';
import { Dropdown, IDropdownOption } from 'office-ui-fabric-react/lib/Dropdown';
import { useState, useEffect } from 'react';
import formatMessage from 'format-message';

import { container, dropdownStyles, text } from './style';

Expand Down Expand Up @@ -57,6 +58,7 @@ export const Pagination: React.FC<IPaginationProps> = props => {
styles={dropdownStyles}
selectedKey={`page${index + 1}`}
onChange={handlePageSelected}
ariaLabel={formatMessage('Page number')}
/>
<span css={text}>of {pageCount}</span>
<DefaultButton text="Next >" allowDisabledFocus onClick={hangleNextClick} disabled={index === pageCount - 1} />
Expand Down
1 change: 1 addition & 0 deletions Composer/packages/client/src/pages/notifications/NotificationHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export const NotificationHeader: React.FC<INotificationHeader> = props => {
options={createOptions()}
styles={dropdownStyles}
data-testid="notifications-dropdown"
ariaLabel={formatMessage('Notification type')}
/>
</div>
);
Expand Down
6 changes: 3 additions & 3 deletions Composer/packages/client/src/pages/notifications/NotificationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const columns: IColumn[] = [
},
},
{
key: 'Notification Type',
key: 'NotificationType',
name: 'Type',
className: notification.columnCell,
fieldName: 'type',
Expand All @@ -59,7 +59,7 @@ const columns: IColumn[] = [
isPadded: true,
},
{
key: 'Notification Location',
key: 'NotificationLocation',
name: 'Location',
className: notification.columnCell,
fieldName: 'location',
Expand All @@ -73,7 +73,7 @@ const columns: IColumn[] = [
isPadded: true,
},
{
key: 'Notification Detail',
key: 'NotificationDetail',
name: 'Message',
className: notification.columnCell,
fieldName: 'message',
Expand Down