Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default hint in trigger wizard will introduce error #2910

Closed
hibrenda opened this issue May 6, 2020 · 4 comments
Closed

Default hint in trigger wizard will introduce error #2910

hibrenda opened this issue May 6, 2020 · 4 comments
Assignees
@feich-ms @zhixzhan
Labels
R9-RC Type: Bug Something isn't working

Comments

@hibrenda
Copy link
Contributor

hibrenda commented May 6, 2020

image

Checked with ZhiXiang and Fei, this can be mitigate by following

image
@hibrenda hibrenda added the Type: Bug Something isn't working label May 6, 2020
@zhixzhan
Copy link
Contributor

zhixzhan commented May 6, 2020

FYI @feich-ms , I find out it comes from empty comments line e.g

> welcome
>                    // this empty comments line caused a lu parse error
> bye
``

@feich-ms
Copy link
Contributor

feich-ms commented May 6, 2020

Will take a look. Please let me know if this is blocker for R9 release.

@cwhitten cwhitten added the R9-RC label May 7, 2020
@cwhitten
Copy link
Member

cwhitten commented May 7, 2020

yes we should address this

@feich-ms feich-ms mentioned this issue May 7, 2020
Merged
@feich-ms
Copy link
Contributor

feich-ms commented May 7, 2020

Fixed in this PR microsoft/botframework-cli#763 which is targetting BF-CLI next RC

@lei9444 lei9444 mentioned this issue May 7, 2020
Merged
@lei9444 lei9444 mentioned this issue May 8, 2020
Merged
@cwhitten cwhitten closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feich-ms feich-ms

@zhixzhan zhixzhan

Labels
R9-RC Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cwhitten @feich-ms @hibrenda @zhixzhan