Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bootstrap to 5.x #650

Open
scovetta opened this issue Apr 16, 2022 · 2 comments
Open

Bump Bootstrap to 5.x #650

scovetta opened this issue Apr 16, 2022 · 2 comments
Labels
bug Something isn't working good first issue

Comments

@scovetta
Copy link
Member

Describe the bug
Bootstrap is included in Cli\wwwroot\js. We're using version 4.3.1, which is a bit old and has some non-inclusive language (whitelist), which was changed in version 5.1.

Let's upgrade to the latest version.

@scovetta scovetta added the bug Something isn't working label Apr 16, 2022
@gfs
Copy link
Contributor

gfs commented Apr 29, 2022

I tried to just bump the dependency but upgrading the dependencies without changing some elements of the ux seems to break a bunch of formatting so we can't just bump the dependency.

I'll try to set aside some with with David to perform the upgrade.

Since this pulls in OAT blazor components we might also need to upgrade that.

@gfs
Copy link
Contributor

gfs commented Jul 14, 2022

Now possible to complete thanks to @daalcant completing. microsoft/OAT#150

gfs added a commit that referenced this issue Jun 26, 2024
* #650 bump bootstrap version

* Bump to Bootstrap 5.3.3

* Readme cleanup

---------

Co-authored-by: Gabe Stocco <98900+gfs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue
Projects
None yet
Development

No branches or pull requests

2 participants