Adds Analyze Single vs Multi-thread benchmark #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to concurrentstack instead of list internally
Dramatically improves speed and reliability.
guyacosta
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds benchmarks for Single vs Multithreaded Analysis (Manual path setup currently)
Adds some fixes for multi-threaded reliability.
Changes to using
HashSet<string>toConcurrentDictionary<string,byte>for thread safety in many cases. HashSet is not thread safe. UseTryAdd(item,0)anditem = dict[key].Key, and ignore the byte assigned to each key.Changes to using
ConcurrentStack<string>instead ofList<string>inside multithreaded extractor for thread safety.Delete autogenerated default rules from source.