Zero length files (#203)

* Better handling for project default name when source path is current or .\ * Fix for #179 to add check for existing log config * Fix #200 * Check for zero length files to scan which can cause exceptions on archive type check.
microsoft · May 7, 2020 · 6a6da3b · 6a6da3b
1 parent 4ab3098
commit 6a6da3b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/AppInspector/Commands/AnalyzeCommand.cs b/AppInspector/Commands/AnalyzeCommand.cs
@@ -299,6 +299,13 @@ public AnalyzeResult GetResult()
                 // Iterate through all files and process against rules
                 foreach (string filename in _srcfileList)
                 {
+                    if (new FileInfo(filename).Length == 0)
+                    {
+                        WriteOnce.SafeLog(MsgHelp.FormatString(MsgHelp.ID.ANALYZE_EXCLUDED_TYPE_SKIPPED, filename), LogLevel.Warn);
+                        _metaDataHelper.Metadata.FilesSkipped++;
+                        continue;
+                    }
+
                     ArchiveFileType archiveFileType = ArchiveFileType.UNKNOWN;
                     try //fix for #146
                     {

diff --git a/AppInspector/Resources/defaultRulesPkd.json b/AppInspector/Resources/defaultRulesPkd.json
@@ -11156,7 +11156,7 @@
     "overrides": null,
     "patterns": [
       {
-        "pattern": "\\b(WindowsImpersonationContext|WindowsIdentity\\.Impersonate|WindowsIdentity\\.RunImpersonated||ImpersonateIdentity)\\b",
+        "pattern": "\\b(WindowsImpersonationContext|WindowsIdentity\\.Impersonate|WindowsIdentity\\.RunImpersonated|ImpersonateIdentity)\\b",
         "type": "regex",
         "modifiers": null,
         "scopes": [
@@ -14003,9 +14003,9 @@
     "conditions": []
   },
   {
-    "name": "Testing Framework: ",
+    "name": "Testing Framework: JSUnit",
     "id": "AI042000",
-    "description": "Testing Framework: ",
+    "description": "Testing Framework: JSUnit",
     "applies_to": [
       "javascript"
     ],