Fix Issues with Confidence Display on Key Features Page of HTML Report (

#553) * Remove legacy files from separate rules repo * Switch Tag Detection for Features page to Regex And update all search patterns to be regular expression istead of exact match * Update Dependencies
microsoft · Jul 25, 2023 · 4bb352a · 4bb352a
1 parent 774ba64
commit 4bb352a
Show file tree

Hide file tree

Showing 13 changed files with 114 additions and 253 deletions.
diff --git a/AppInspector.Benchmarks/AppInspector.Benchmarks.csproj b/AppInspector.Benchmarks/AppInspector.Benchmarks.csproj
@@ -10,8 +10,8 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
-        <PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.5" />
+        <PackageReference Include="BenchmarkDotNet" Version="0.13.6" />
+        <PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.6" />
 
     </ItemGroup>
     <ItemGroup>

diff --git a/AppInspector.CLI/AppInspector.CLI.csproj b/AppInspector.CLI/AppInspector.CLI.csproj
@@ -67,8 +67,8 @@
 
     <ItemGroup>
         <PackageReference Include="DotLiquid" Version="2.2.692" />
-        <PackageReference Include="Sarif.Sdk" Version="4.2.0" />
-        <PackageReference Include="Serilog" Version="2.12.0" />
+        <PackageReference Include="Sarif.Sdk" Version="4.2.2" />
+        <PackageReference Include="Serilog" Version="3.0.1" />
         <PackageReference Include="Serilog.Extensions.Logging" Version="7.0.0" />
         <PackageReference Include="Serilog.Sinks.Console" Version="4.1.0" />
         <PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />

diff --git a/AppInspector.CLI/Writers/AnalyzeHtmlWriter.cs b/AppInspector.CLI/Writers/AnalyzeHtmlWriter.cs
@@ -279,7 +279,7 @@ public void PopulateTagGroups()
             foreach (var pattern in tagGroup.Patterns ?? new List<TagSearchPattern>())
             {
                 pattern.Detected = _appMetaData?.UniqueTags is not null &&
-                                   _appMetaData.UniqueTags.Any(v => v == pattern.SearchPattern);
+                                   _appMetaData.UniqueTags.Any(v => pattern.Expression.IsMatch(v));
                 if (unSupportedGroupsOrPatterns.Any(x => pattern.SearchPattern.ToLower().Contains(x)))
                 {
                     _logger.LogWarning(