Statsbeat do not count failed request when throttle

[hectorhdzg]

No description provided.

[lzchen]

I believe 429 is also a retry scenario.

[hectorhdzg]

So, we send Statsbeat metrics for throttle and retry, @heyams can you confirm?

[heyams]

we do retry on 429. no retry on 439, which is throttling.

[heyams]

can you only add 439 to throttling count in Statsbeat and then count 429 as failure? that's what we do in java.

[heyams]

@hectorhdzg here is breeze's definition of these 2 response codes:

 **429 - Too many requests**
  The client send too many telemetries to the endpoint within in the given time interval so it is throttled

* **439 - Too many requests and refresh cache**
  The client is throttled at one point so frequently that the endpoint would send it 439 status code saying that it is throttled and should not retry for a long time.
Then, the client would drop the current data from its buffers. (i.e. Monthly Quota Exceeded)

[hectorhdzg]

Thanks @heyams, this PR will actually fix issue where we do not retry in Throttle as well, as other PR was using wrong code #910

• 439 - Too many requests and refresh cache

  The client is throttled at one point so frequently that the endpoint would send it 439 status code saying that it is throttled and should not retry for a long time.
  Then, the client would drop the current data from its buffers.

[heyams]

👍

[heyams]

@hectorhdzg let's chat tomorrow if we want to send two count to breeze.. daily quota exceeded vs. monthly quota exceeded.