Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong telemetrytype in qps conversion #500

Merged
merged 1 commit into from
Apr 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Declarations/Constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,20 +75,20 @@ export const QuickPulseType: {[key in Contracts.TelemetryTypeKeys]: QuickPulseTy
Dependency: "DependencyTelemetryDocument"
};

export const TelemetryTypeStringToQuickPulseType: {[key in Contracts.TelemetryTypeKeys]: QuickPulseType} = {
Event: QuickPulseType.Event,
Exception: QuickPulseType.Exception,
Trace: QuickPulseType.Trace,
Metric: QuickPulseType.Metric,
Request: QuickPulseType.Request,
Dependency: QuickPulseType.Dependency,
export const TelemetryTypeStringToQuickPulseType: {[key in Contracts.TelemetryTypeValues]: QuickPulseType} = {
EventData: QuickPulseType.Event,
ExceptionData: QuickPulseType.Exception,
MessageData: QuickPulseType.Trace,
MetricData: QuickPulseType.Metric,
RequestData: QuickPulseType.Request,
RemoteDependencyData: QuickPulseType.Dependency
};

export const TelemetryTypeStringToQuickPulseDocumentType: {[key in Contracts.TelemetryTypeKeys]: QuickPulseDocumentType} = {
Event: QuickPulseDocumentType.Event,
Exception: QuickPulseDocumentType.Exception,
Trace: QuickPulseDocumentType.Trace,
Metric: QuickPulseDocumentType.Metric,
Request: QuickPulseDocumentType.Request,
Dependency: QuickPulseDocumentType.Dependency,
export const TelemetryTypeStringToQuickPulseDocumentType: {[key in Contracts.TelemetryTypeValues]: QuickPulseDocumentType} = {
EventData: QuickPulseDocumentType.Event,
ExceptionData: QuickPulseDocumentType.Exception,
MessageData: QuickPulseDocumentType.Trace,
MetricData: QuickPulseDocumentType.Metric,
RequestData: QuickPulseDocumentType.Request,
RemoteDependencyData: QuickPulseDocumentType.Dependency
};
4 changes: 2 additions & 2 deletions Library/QuickPulseEnvelopeFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ class QuickPulseEnvelopeFactory {


if (envelope.data.baseType) {
__type = Constants.TelemetryTypeStringToQuickPulseType[envelope.data.baseType as Contracts.TelemetryTypeKeys];
documentType = Constants.TelemetryTypeStringToQuickPulseDocumentType[envelope.data.baseType as Contracts.TelemetryTypeKeys];
__type = Constants.TelemetryTypeStringToQuickPulseType[envelope.data.baseType as Contracts.TelemetryTypeValues];
documentType = Constants.TelemetryTypeStringToQuickPulseDocumentType[envelope.data.baseType as Contracts.TelemetryTypeValues];
} else {
// Remark: This should never be hit because createQuickPulseDocument is only called within
// valid baseType values
Expand Down
21 changes: 21 additions & 0 deletions Tests/Library/QuickPulseEnvelopeFactory.tests.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import assert = require("assert");
import sinon = require("sinon");

import Contracts = require("../../Declarations/Contracts");
import Constants = require("../../Declarations/Constants");

describe("Library/QuickPulseEnvelopeFactory", () => {
describe("QPS Constants", () => {
it("should convert TelemetryTypeValues to QuickPulseType", () => {
const keys = Object.keys(Contracts.TelemetryTypeString);
assert.ok(keys.length > 0);
keys.forEach((key: Contracts.TelemetryTypeKeys) => {
const value = Contracts.TelemetryTypeString[key];
const qpsType = Constants.TelemetryTypeStringToQuickPulseType[value];
const qpsDocType = Constants.TelemetryTypeStringToQuickPulseDocumentType[value];
assert.equal(qpsType, Constants.QuickPulseType[key]);
assert.equal(qpsDocType, Constants.QuickPulseDocumentType[key]);
})
});
});
});