setting userAuthUserId tag from ai_authUser cookie field #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! Looks great! |
| @@ -122,6 +123,7 @@ describe("AutoCollection/HttpRequestParser", () => { | |||
| var newTags = helper.getRequestTags(originalTags); | |||
| assert.equal(newTags[(<any>HttpRequestParser).keys.locationIp], 'originalIp'); | |||
| assert.equal(newTags[(<any>HttpRequestParser).keys.userId], 'originalUserId'); | |||
| assert.equal(newTags[(<any>HttpRequestParser).keys.userAuthUserId], 'originalAuthUserId'); | |||
There was a problem hiding this comment.
You might want to add another assertion like this to the next section "should read tags from headers"
There was a problem hiding this comment.
Yep! I didn't notice the next section.
Done!
There was a problem hiding this comment.
@OsvaldoRosado I still dont know why the tests failed...
There was a problem hiding this comment.
Looks like something changed in the test environment. I'll look into this
OsvaldoRosado
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small contribution to populate
userAuthUserIdfromai_authUsercookie field (likeai_user)Seems that also concerns #356