Updated diagnostic-channel, added subscribers for winston and pg #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackhorton, |
|
Thanks! We should update the README with the new packages supported by autocollection |
|
I can add that. Any ideas why the Node 4.x build would just not produce any output like that? I can try to test locally with node 4 to make sure? |
|
I'd guess the issue with node 4.1 is some travis infrastructure, and hopefully once you push a readme change it'll re-run and work. Note that the other 4.x runs worked fine. |
OsvaldoRosado
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
diagnostic-channel-publishers@0.2.0 added new publishers for pg@6.x, pg-pool@1.x, and winston@2.x, so I have added subscribers for those as well. Finally, I noticed that mongoCore was not being brought in and enabled by default, so I fixed that as well.
I checked that it built and passed all tests as well.