Fix flaky unit test failures in "Offline mode: disabled by default" #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilSzostak
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #273
This test spuriously failed very frequently due to a race condition with the code to get AppId in
CorrelationIdManager. Root cause is the way these tests mock out https.request. The AppId call registers an error handler with the mocked request, which immediately calls the registered fail handler, which will sometimes be the test case's callback. This causes the callback to be called multiple times.The fix here is to stub out the logic that queries for correlation id during the offline mode E2E tests that do this broken mocking of https.request. A full fix later that allows the AppId logic to remain without mocking would be to use more complicated stubs (like the one seen in EndToEnd/Basic Usage)