Use autogenerated schemas #228

OsvaldoRosado · 2017-04-15T00:07:26Z

This PR will:

Update BOND files to latest version
Regenerate contracts from the BOND using a new autogeneration format that has comments and uses require
Remove all code reliant on older schemas (old perfcollector reporting for example)
Update all code to use the autogenerated contracts rather than a hand modified file

Addresses issues:
#122
#162
#192

…ration

…ed schema classes

# Conflicts: # AutoCollection/ClientRequestParser.ts

OsvaldoRosado · 2017-04-15T00:42:30Z

Library/Client.ts

-                        data.baseData.properties[name] = this.commonProperties[name];
+        data: Contracts.Data<Contracts.Domain>,
+        tagOverrides?: { [key: string]: string; }): Contracts.Envelope {
+        if (Contracts.domainSupportsProperties(data.baseData)) { // Do instanceof check. TS will automatically cast and allow the properties property


This is slightly different logic, but I think it is more correct (plus type safe!). The difference is the previous logic would dump a default properties property on any supplied baseData. While all of our data types support this key, it is not on the base Domain class, so new ones may intentionally not have it. This will only supply the properties object if the type allows for it (or one already exists). This is done by trying to cast against the new ISupportProperties interface. This is similar to the approach used in .NET

OsvaldoRosado · 2017-04-15T00:44:37Z

AutoCollection/ServerRequestParser.ts

@@ -88,7 +88,6 @@ class ServerRequestParser extends RequestParser {
        newTags[ServerRequestParser.keys.locationIp] = tags[ServerRequestParser.keys.locationIp] || this._getIp();
        newTags[ServerRequestParser.keys.sessionId] = tags[ServerRequestParser.keys.sessionId] || this._getId("ai_session");
        newTags[ServerRequestParser.keys.userId] = tags[ServerRequestParser.keys.userId] || this._getId("ai_user");
-        newTags[ServerRequestParser.keys.userAgent] = tags[ServerRequestParser.keys.userAgent] || this.userAgent;


This field was dropped from the schema - so its logic is removed here accordingly

OsvaldoRosado · 2017-04-15T00:45:29Z

AutoCollection/Performance.ts

@@ -208,10 +163,6 @@ class AutoCollectPerformance {
            this._client.trackMetric(combinedName + "nice", totalNice / combinedTotal);


These metric names have to be verified for correctness as the legacy perfcounters are removed with these changes.

Had offline discussion. Will keep the clean trackMetric names and ensure compatibility is kept on backend for legacy name conversion

SergeyKanzhelev · 2017-04-17T15:39:40Z

package.json

@@ -27,6 +27,10 @@
      "email": "kszostak@microsoft.com"
    },
    {
+      "name": "osrosado",


let's replace individual names to the AppInsightsSDK account

Done. What are your thoughts on aidevsupport@microsoft? I've left it for now, but we can remove it in favor of only appinsightssdk

SergeyKanzhelev

thanks, looks good

…/ApplicationInsights-node.js into osrosado/updateschemas

AlexBulankou · 2017-04-27T15:23:54Z

Tests/Library/Client.tests.ts

@@ -626,7 +626,7 @@ describe("Library/Client", () => {
            client1.commonProperties = commonproperties;
            client1.config.samplingPercentage = 99;
            mockData.baseData.properties = JSON.parse(JSON.stringify(properties));
-            var env = client1.getEnvelope(mockData);
+            var env = <any>client1.getEnvelope(mockData);


Why do we need <any>, isn't sample rate specified on Contracts.Envelope?

IIRC it's not casted because of sample rate, but the basedata assertions. The base type in our schema doesn't have the properties object.

OsvaldoRosado · 2017-04-28T18:14:41Z

AutoCollection/Performance.ts

-            // todo: remove this legacy counter once the UI updates (~june 2015)
-            this._trackLegacyPerformance(PerfCounterType.ProcessorTime, totalUser / combinedTotal);
-            this._trackLegacyPerformance(PerfCounterType.PercentProcessorTime, (combinedTotal - totalIdle) / combinedTotal);
+            this._client.trackMetric("\\Processor(_Total)\\% Processor Time", (combinedTotal - totalIdle) / combinedTotal);


Following more offline discussions, common perf counters with .NET SDKs will be reported using the metric names they currently use until a new set is decided. There should be no user impact, as these are converted into appropriate values in the performanceCounter Analytics table by the backend

* Add build script command * Adds schema and typescript files to npmignore * Add tagOverrides and contextObjects (#210) * Add tagOverrides and contextObjects Also updated documentation. Yes, it's 1 commit. Yes, I'm a terrible person for doing that. * Add contextObject + formatting * Fix CORS error when using library with browserify Fixes an obscure problem when trying to use the ApplicationInsights node.js library with a browserify application. * Add missing docs (#218) * Update cross component dependency type (#219) * migrate from typings to @types (#221) * Add sampling support (#217) * Add sampling support * Fix test failure * Update readme * Fix race condition in readme example * Fix build error from typings changes * update package install and build scripts (#224) * update package install and build scripts * Adds a prepare script to replace the prepublish script for `npm install` in npm@5+. * Built artifacts from tsc are aggregated and stored in ./out for easier workspace management. * New test case which isn't transpiled by tsc to test some scenarios. Includes a test for loading the transpiled module. PR-URL: Reviewed-By: Reviewed-By: * fixup! update package install and build scripts * edits to comments in applicationinsights.ts (#223) * edits to comments * fixup! edits to comments * Use autogenerated schemas (#228) * Update BOND schema, update generated typescript with new comment generation * Update autogenerated schemas. Migrate project to only use autogenerated schema classes * Fix build errors * Address PR feedback * Add missing metric * Change metric names to be in line with .NET SDK for common metrics * Fix broken percentage units in performance counters * pick up generated Declaration submodule (#232) * Set the host app version to the context tags. #183 (#233) * Sets version to the context tags * No Readme changes * Correct unit test * Update Client.ts Typo on the comment solved and switched the method name from setVersion to overrideApplicationVersion. * Update Client.tests.ts I apologize for the inconvenience, unit test corrected. * Updating how cross-application correlations are tracked (#231) * Updating how cross-application correlations are tracked Instead of using a hash of the instrumentation key we now use the appId, matching the .NET sdk. We also use different headers to match the .NET sdk. * Updating to only issue appId requests once per ikey * Exposing profileQueryEndpoint property Allows for the appId query target to be configured separately to the telemetry endpoint. It may be specified either by the APPINSIGHTS_PROFILE_QUERY_ENDPOINT environment variable, or explicitly via client.config.profileQueryEndpoint. Note that it must be set synchronously with the creation of the Config otherwise the value will not be used. * Allowing appId lookups to be cancelled if a new endpoint is specified * Adding operationId to outbound HTTP headers * Provide access to contracts (#234) * Provide access to contracts * Test for access to contracts * Change access to Contracts from Client.ts to applicationinsights.ts * Fix baseTypes (#236) * update README * address Alex's feedback * Fixing CorrelationId There was a typo which lead to the `correlationIdPrefix` being null. * Adding diagnostic-channel (#235) * Adding diagnostic-channel By using diagnostic-channel and diagnostic-channel-publishers, we can support context tracking through third-party libraries as well as getting additional telemetry for those dependencies. * Fixing cyclical reference and supporting multiple AI clients in diagnostic-channel subscribers * Updating readme with diagnostic-channel information * Update Readme (#238) * Enable automatic correlation by default (#239) * Include typescript definitions in NPM package (#240) * Update package.json to 0.20 (#241)

OsvaldoRosado added 4 commits April 13, 2017 11:18

Update BOND schema, update generated typescript with new comment gene…

562a294

…ration

Update autogenerated schemas. Migrate project to only use autogenerat…

611db67

…ed schema classes

Merge branch 'develop' into osrosado/updateschemas

ca18a68

# Conflicts: # AutoCollection/ClientRequestParser.ts

Fix build errors

6bc18e8

msftclas added the cla-already-signed label Apr 15, 2017

OsvaldoRosado commented Apr 15, 2017

View reviewed changes

Merge branch 'develop' into osrosado/updateschemas

e79f51b

SergeyKanzhelev reviewed Apr 17, 2017

View reviewed changes

SergeyKanzhelev approved these changes Apr 17, 2017

View reviewed changes

OsvaldoRosado added 3 commits April 17, 2017 09:55

Address PR feedback

09388f8

Merge branch 'osrosado/updateschemas' of https://github.com/Microsoft…

ae03f48

…/ApplicationInsights-node.js into osrosado/updateschemas

Add missing metric

a946ae2

AlexBulankou reviewed Apr 27, 2017

View reviewed changes

Change metric names to be in line with .NET SDK for common metrics

b055e24

OsvaldoRosado commented Apr 28, 2017

View reviewed changes

Fix broken percentage units in performance counters

8ef0b49

OsvaldoRosado merged commit 7b145dc into develop Apr 29, 2017

joshgav mentioned this pull request May 1, 2017

don't exclude Declarations folder #232

Merged

OsvaldoRosado deleted the osrosado/updateschemas branch May 11, 2017 00:30

OsvaldoRosado mentioned this pull request Jul 17, 2017

Types generated from the public schema should contain comments. microsoft/ApplicationInsights-JS#375

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use autogenerated schemas #228

Use autogenerated schemas #228

OsvaldoRosado commented Apr 15, 2017

OsvaldoRosado Apr 15, 2017 •

edited

Loading

OsvaldoRosado Apr 15, 2017

OsvaldoRosado Apr 15, 2017

OsvaldoRosado Apr 17, 2017

SergeyKanzhelev Apr 17, 2017

OsvaldoRosado Apr 17, 2017 •

edited

Loading

SergeyKanzhelev left a comment

AlexBulankou Apr 27, 2017 •

edited

Loading

OsvaldoRosado Apr 27, 2017

OsvaldoRosado Apr 28, 2017

		@@ -208,10 +163,6 @@ class AutoCollectPerformance {
		this._client.trackMetric(combinedName + "nice", totalNice / combinedTotal);

Use autogenerated schemas #228

Use autogenerated schemas #228

Conversation

OsvaldoRosado commented Apr 15, 2017

OsvaldoRosado Apr 15, 2017 • edited Loading

Choose a reason for hiding this comment

OsvaldoRosado Apr 15, 2017

Choose a reason for hiding this comment

OsvaldoRosado Apr 15, 2017

Choose a reason for hiding this comment

OsvaldoRosado Apr 17, 2017

Choose a reason for hiding this comment

SergeyKanzhelev Apr 17, 2017

Choose a reason for hiding this comment

OsvaldoRosado Apr 17, 2017 • edited Loading

Choose a reason for hiding this comment

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

AlexBulankou Apr 27, 2017 • edited Loading

Choose a reason for hiding this comment

OsvaldoRosado Apr 27, 2017

Choose a reason for hiding this comment

OsvaldoRosado Apr 28, 2017

Choose a reason for hiding this comment

OsvaldoRosado Apr 15, 2017 •

edited

Loading

OsvaldoRosado Apr 17, 2017 •

edited

Loading

AlexBulankou Apr 27, 2017 •

edited

Loading