update README and rename LICENSE #222
Conversation
README.md
Outdated
|
|
||
| ### Disabling automatic collection | ||
| To correlate events in a request across callbacks and dependencies, you'll need | ||
| to call `.setAutoDependencyCorrelation(true)`. |
There was a problem hiding this comment.
Instead of calling setAutoDependencyCorrelatio out separately, I would include a comment for each entry below
README.md
Outdated
| .setAutoCollectExceptions(false) | ||
| .setAutoCollectDependencies(false) | ||
| // no telemetry will be sent until .start() is called | ||
| .setAutoDependencyCorrelation(false) |
There was a problem hiding this comment.
Why is false default (without explanation)
There was a problem hiding this comment.
@OsvaldoRosado set it up that way originally, discussion here on defaulting to true beginning in 0.20. I'll update this based on outcome there, in the meantime will note that this is experimental.
| res.writeHead(200, { "Content-Type": "text/plain" }); | ||
| res.end("Hello World\n"); | ||
| }).listen(port); | ||
| * Manually track all HTTP GET requests |
There was a problem hiding this comment.
Probably mention that in this case you want to set .setAutoCollectRequests(true)?
There was a problem hiding this comment.
Do you mean .setAutoCollectRequests(false)? I added that now.
657974d to
99e6695
Compare
|
@OsvaldoRosado @AlexBulankou updated this to address your feedback, PTAL. I'll do another pass in a few days, I think this can be merged now though if you'd like. Thanks! |
|
|
No description provided.