HTTP dependency request tracking #130
Conversation
Add automatic collection of dependency HTTP request data.
|
|
| remoteDependency.async = true; | ||
| remoteDependency.dependencyTypeName = | ||
| ContractsModule.Contracts.DependencyKind[ContractsModule.Contracts.DependencyKind.Http]; | ||
| remoteDependency.dependencyKind = ContractsModule.Contracts.DependencyKind.Http; |
There was a problem hiding this comment.
I believe a new dependency type, something called AI dependency, is being introduced, and that would be used instead of HTTP for communications between AI components.
Check with Nizar on the details.
There was a problem hiding this comment.
Yes, I'll include that in the follow-up change that adds component correlation. But for now this code doesn't know when a dependency is an AI component or not.
| // response listeners | ||
| if (response && response.once) { | ||
| response.once("finish", () => { | ||
| AutoCollectServerRequests.endRequest(client, requestParser, response, null, properties, null); |
There was a problem hiding this comment.
I just noticed that in both the Server and Client auto collectors, it's currently not parsing or generating a hashed ikey and on the HTTP headers. This will be needed for stitching different AI components in the map. Perhaps that's the next step?
There was a problem hiding this comment.
Yes, that will be in a separate PR. I'm testing that now.
I'm resubmitting this as a new PR to target the develop branch instead of the master branch. See review comments on the original PR at #129. There are no changes here compared to that one, aside from rebasing on top of develop.