[Beta] Updating Azure Function Hook logic #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Feb 3, 2023
| @@ -13,19 +13,17 @@ export class AzureFunctionsHook { | |||
| constructor() { | |||
| try { | |||
| this._functionsCoreModule = require("@azure/functions-core"); | |||
| // Only v3 of Azure Functions library is supported right now. See matrix of versions here: | |||
| // https://github.com/Azure/azure-functions-nodejs-library | |||
| const funcProgModel = this._functionsCoreModule.getProgrammingModel(); | |||
There was a problem hiding this comment.
It shouldn't but if that happens the catch will take care of it. I don't believe we want to do anything if we cannot get the programming model.
MSNev
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding azure/funciton-core types
Removing auto generation of server spans and only support context propagation for now
Updating OpenTelemetry dependencies