Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trackNodeHttpRequest does not follow type contract #365

Closed
OsvaldoRosado opened this issue Jan 11, 2018 · 0 comments
Closed

trackNodeHttpRequest does not follow type contract #365

OsvaldoRosado opened this issue Jan 11, 2018 · 0 comments
Labels
bug
Milestone
1.0.2

Comments

@OsvaldoRosado
Copy link
Member

trackNodeHttpRequest says it accepts all parameters of type Telemetry, when it actually only uses request, response, and properties, and ignores all others.
OsvaldoRosado added a commit that referenced this issue Feb 8, 2018
@OsvaldoRosado
Address issue #365
0ce908d
@OsvaldoRosado OsvaldoRosado added this to the 1.0.2 milestone Feb 8, 2018
@OsvaldoRosado OsvaldoRosado mentioned this issue Feb 8, 2018
Merged
OsvaldoRosado added a commit that referenced this issue Feb 21, 2018
@OsvaldoRosado
Fix bugs for 1.0.2 (#369)
c992f39 
* Fix issue #362

* Fix issue #358

* Fix issue #346

* Fix issue #344

* Address issue #368

* Address issue #365

* Add additional logging and fix stability issues with retry caching

* Bump package.json

* Add calls to ICACLS for windows

* Address PR feedback

* Fix unit tests in Node < 0.11.12

* Fix more unit tests for Node < 0.11.12

* Fix again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
1 participant
@OsvaldoRosado