Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userid is not autocollected from the cookies #31

Closed
MaxShehovtsov opened this issue Aug 20, 2015 · 2 comments
Closed

Userid is not autocollected from the cookies #31

MaxShehovtsov opened this issue Aug 20, 2015 · 2 comments

Comments

@MaxShehovtsov
Copy link

JSSDK sets ai_user cookie which should be associated with the request. NodeSDK does parse ai_session cookie but doesn't look at ai_user.

@gzepeda
Copy link
Contributor

gzepeda commented Jun 3, 2016

As a proposal to solve this issue the RequestDataHelper class needs to be modified:

  • Add a method like _getUser() similar to the _getSessionId() present in this class that retrieves that information.
  • Add a call to the previous method on the getRequestTags function to populate the tag corresponding to the user retrieved from the previous method.

Let us now.
@georgejolema
@AlexBulankou
@oscargarciacolon

gzepeda added a commit to gzepeda/ApplicationInsights-node.js that referenced this issue Jun 9, 2016
KamilSzostak pushed a commit that referenced this issue Jun 10, 2016
Resolving #31 - Userid is not autocollected from the cookies
@KamilSzostak
Copy link

@gzepeda looks good to me :) Thanks for fixing this issue!

@KamilSzostak KamilSzostak added this to the v 0.15.17 milestone Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants