Sensors from JSON and more #2 #3502
Conversation
updated python files
Seems to be a duplicate of the PythonClient dir.
|
@rajat2004 I implemented your feedback. I will write documentation soon. |
| real_T update_latency = 0.0f; //sec | ||
| real_T update_frequency = 50; //Hz | ||
| real_T startup_delay = 0; //sec | ||
| Vector3r position = VectorMath::nanVector(); |
There was a problem hiding this comment.
position is unused as well, can be removed. Same for IMU, GPS and Magnetometer
There was a problem hiding this comment.
Thanks, I removed them.
|
@lovettchris is it correct you added the functionality of this PR already with PR #3546? If I look at the merge conflicts that seems to be the case. I mean commit 006d4e2 specifically. Because if it is already merged, this PR can be closed. |
|
Hi yes, I did that change. It looks like we both tackled the same problem, but implemented it in a slightly different way. Instead of populating all the fields in those structs in AirSimSettings.hpp like struct BarometerSetting, struct ImuSetting, struct GpsSetting, and so on, I instead decided to place the Json object inside the base class SensorSetting. This allows the json to be parsed instead inside each sensor actual *SimpleParams.hpp file. The reason I prefer this is because this way the "default values" for each sensor is kept in one place, namely the actual *SimpleParams.hpp files removing the duplication of default values from AirSimSettings.hpp. |
|
Thanks for the explanation. I indeed prefer your method as well, nice to see that it is now on master. I will close this PR then, because it has no further value. #2821 can also be closed, because it is an old version of this PR. |
|
sounds good, thanks. |
Duplicate of #2821, but now without merge conflicts.
About
Proposing a few changes here:
-Added ability to load parameters for JSON for Barometer, Distance Sensor, IMU, GPS, Magnetometer
-Small change to python types doc, fixes a change I proposed before with better datatypes (float vs quaternion) for distance sensor
-Small change to documentation on linux build, sometimes deleting the 'binaries' and 'intermediate' folders in your unreal project after rebuilding airsim can fix errors where unreal tries to open content that doesnt exist anymore and causes the 'try rebuilding from source' error
-small change to move on path, replaces the position PID to use the velocity PID when traveling at constant altitude, elimnates shake problems
TODO:
-did not update documentation to show the new fields available for settings...
I implemented most of the feedback of #2821. But the indentation of some files is still incorrect and there are irrelevant changes in the PR.