Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified the simulation time #3158

Merged
merged 2 commits into from
Feb 10, 2021
Merged

unified the simulation time #3158

merged 2 commits into from
Feb 10, 2021

Conversation

kemen209
Copy link
Contributor

make it work under steppable-clock.

Maybe related to #3010.

…e have scalaable-clock and steppable-clock

(cherry picked from commit 1a3b58e)
@ghost
Copy link

ghost commented Nov 20, 2020

CLA assistant check
All CLA requirements met.

@jonyMarino jonyMarino added the px4 label Dec 31, 2020
@zimmy87
Copy link
Contributor

zimmy87 commented Jan 5, 2021

Hi @kemen209, how was this PR tested?

@kemen209
Copy link
Contributor Author

Hi @zimmy87, i try the following setting on my local machine:

setting.json

"ClockType": "SteppableClock",
"ClockSpeed": 1.0,

And i use some debugging trick to slow down the simu clock, and it worked as i expected: simu clock only move one step, but the wall clock may passed hundreds of seconds.

Besides this, no other tests, like auto test involved.

From my understanding, this bug only a problem when use 'SteppableClock' with slow or faster simu clock.

@zimmy87
Copy link
Contributor

zimmy87 commented Feb 10, 2021

Thank you for submitting this PR @kemen209! I tested this locally and it appears to work as intended, so I am merging this. This also fixed #3010 for me, so I will refer people to this fix in that issue.

@zimmy87 zimmy87 merged commit 0096b5e into microsoft:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants