Make sure each buffer is zero'd out before reading bytes. Remove unne…

…cessary metadata from mavlink messages and make tooltips show on top of close box in the charts.

.gitignore

@@ -386,4 +386,3 @@ build_docs/
 
 # api docs
 PythonClient/docs/_build
-/LogViewer/LogViewer/publish.cmd

LogViewer/LogViewer/Controls/SimpleLineChart.xaml

@@ -33,14 +33,6 @@
         <Canvas Grid.Row="0" VerticalAlignment="Top">
             <Path x:Name="Graph" StrokeThickness="5" VerticalAlignment="Top" SnapsToDevicePixels="True" StrokeLineJoin="Bevel">
             </Path>
-            <Path x:Name="Pointer" Fill="{StaticResource TooltipForeground}" Data="M0,-5 L 5,0 0,5 -5 0z" Visibility="Collapsed"/>
-            <local:PointerBorder x:Name="PointerBorder"  Visibility="Collapsed" Padding="2" HorizontalAlignment="Left" VerticalAlignment="Top" BorderThickness="1"
-                    CornerRadius="3" BorderBrush="{StaticResource TooltipForeground}" Background="#80303030">
-                <TextBlock x:Name="PointerLabel" Foreground="{StaticResource TooltipForeground}"/>
-            </local:PointerBorder>
-            <Canvas x:Name="AdornerCanvas">
-
-            </Canvas>
         </Canvas>
 
         <Grid>
@@ -54,5 +46,16 @@
         </Grid>
 
         <local:CloseBox HorizontalAlignment="Right" VerticalAlignment="Top" Margin="5" Click="CloseBoxClick"/>
+
+        <Canvas Grid.Row="0" VerticalAlignment="Top">
+            <Path x:Name="Pointer" Fill="{StaticResource TooltipForeground}" Data="M0,-5 L 5,0 0,5 -5 0z" Visibility="Collapsed"/>
+            <local:PointerBorder x:Name="PointerBorder"  Visibility="Collapsed" Padding="2" HorizontalAlignment="Left" VerticalAlignment="Top" BorderThickness="1"
+                    CornerRadius="3" BorderBrush="{StaticResource TooltipForeground}" Background="#80303030">
+                <TextBlock x:Name="PointerLabel" Foreground="{StaticResource TooltipForeground}"/>
+            </local:PointerBorder>
+            <Canvas x:Name="AdornerCanvas">
+
+            </Canvas>
+        </Canvas>
     </Grid>
 </UserControl>

LogViewer/LogViewer/LogViewer.csproj

@@ -33,7 +33,7 @@
     <SuiteName>PX4 Log Viewer</SuiteName>
     <CreateWebPageOnPublish>true</CreateWebPageOnPublish>
     <WebPage>publish.htm</WebPage>
-    <ApplicationRevision>62</ApplicationRevision>
+    <ApplicationRevision>63</ApplicationRevision>
     <ApplicationVersion>1.0.0.%2a</ApplicationVersion>
     <UseApplicationTrust>false</UseApplicationTrust>
     <PublishWizardCompleted>true</PublishWizardCompleted>

LogViewer/LogViewer/Model/MavlinkLog.cs

@@ -584,7 +584,8 @@ public async Task Load(string file, ProgressUtility progress)
             this.duration = TimeSpan.Zero;
             bool first = true;
             // QT time is milliseconds from the following epoch.
-            byte[] msgBuf = new byte[256];
+            const int BUFFER_SIZE = 8000;
+            byte[] msgBuf = new byte[BUFFER_SIZE];
             GCHandle handle = GCHandle.Alloc(msgBuf, GCHandleType.Pinned);
             IntPtr ptr = handle.AddrOfPinnedObject();
 
@@ -605,14 +606,17 @@ await Task.Run(() =>
                         {
                             MavLinkMessage header = new MavLinkMessage();
                             header.ReadHeader(reader);
+
+                            Array.Clear(msgBuf, 0, BUFFER_SIZE);
                             int read = s.Read(msgBuf, 0, header.Length);
 
                             if (read == header.Length)
                             {
+                                int id = (int)header.MsgId;
                                 header.Crc = reader.ReadUInt16();
 
                                 bool checkCrc = true;
-                                if ((int)header.MsgId == MAVLink.mavlink_telemetry.MessageId)
+                                if (id == MAVLink.mavlink_telemetry.MessageId)
                                 {
                                     if (header.Crc == 0)  // telemetry has no crc.
                                     {

LogViewer/LogViewer/publish.cmd

@@ -0,0 +1,6 @@
+@echo off
+cd %~dp0
+
+echo Uploading ClickOnce installer for Px4LogViewer
+AzurePublishClickOnce %~dp0publish downloads/Px4LogViewer "%LOVETTSOFTWARE_STORAGE_CONNECTION_STRING%"
+if ERRORLEVEL 1 goto :eof