py/runtime: move MICROPY_PORT_INIT_FUNC to end of mp_init() #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the MICROPY_PORT_INIT_FUNC hook to the end of mp_init(), just before MP_THREAD_GIL_ENTER() so that everything is intialized before the hook is called. The particular case this is trying to fix is for a MICROPY_PORT_INIT_FUNC that makes use of the GIL mutex in a background thread. The mutext must be intialized before MICROPY_PORT_INIT_FUNC is called, othwerwise we end up with a race condition where the background thread could potentially use it before it is intialized.
|
Thanks for the patch, it looks ok. The operations between where Merge in 339d081 |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Oct 28, 2021
when the MTU of the BLE connection is smaller than the 28 bytes of the header. (The smallest possible MTU is 20.) Fixes micropython#5511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the MICROPY_PORT_INIT_FUNC hook to the end of mp_init(), just before MP_THREAD_GIL_ENTER() so that everything is intialized before the hook is called.
The particular case this is trying to fix is for a MICROPY_PORT_INIT_FUNC that makes use of the GIL mutex in a background thread. The mutext must be intialized before MICROPY_PORT_INIT_FUNC is called, othwerwise we end up with a race condition where the background thread could potentially use it before it is intialized.