Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test active conditions for beans defined in super class #307

Merged
merged 2 commits into from
Oct 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,16 @@ public boolean matches(ConditionContext context) {
final Class<?> declaringTypeClass = declaringType.get();
String declaringTypeName = declaringTypeClass.getName();
if (activeSpecClazz != null) {
final String packageName = NameUtils.getPackageName(activeSpecName);
final String simpleName = NameUtils.getSimpleName(activeSpecName);
final String rootName = packageName + ".$" + simpleName;
if (definition.isProxy()) {
final String packageName = NameUtils.getPackageName(activeSpecName);
final String simpleName = NameUtils.getSimpleName(activeSpecName);
final String rootName = packageName + ".$" + simpleName;
return declaringTypeClass.isAssignableFrom(activeSpecClazz) || declaringTypeName.equals(rootName) || declaringTypeName.startsWith(rootName + "$");
} else {
return declaringTypeClass.isAssignableFrom(activeSpecClazz) || activeSpecName.equals(declaringTypeName) || declaringTypeName.startsWith(activeSpecName + "$");
return declaringTypeClass.isAssignableFrom(activeSpecClazz) &&
definition.getClass().getName().startsWith(rootName + "$") // Check if super class def is part of the current spec
|| activeSpecName.equals(declaringTypeName)
|| declaringTypeName.startsWith(activeSpecName + "$");
}
} else {
context.fail(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
public abstract class SimpleBaseTest {

@MockBean(SimpleService.class)
SimpleServiceInterface simpleService() {
SimpleService simpleService() {
return mock(SimpleService.class);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import javax.inject.Singleton;

@Singleton
public class SimpleService implements SimpleServiceInterface {
public class SimpleService {

private SimpleWorker simpleWorker;

Expand Down

This file was deleted.