Bug Fix: Failed to deserialize the date field from a number using the @JsonFormat annotation

[jjhz]

Fixing the inconsistent behavior when deserializing date field annotated with Jackson @jsonformat annotation.

To reproduce the issue

Pojo:

import java.util.Date;

@Serdeable
class Test {
    @JsonFormat(pattern = "yyyy-MM-dd@HH:mm:ss.SSSZ")
    Date value;
}

Deserialize from Json string

{
    "value": 1640995200000
}

Error received:

Error decoding property [Date value] of type [class test.Test]: Text '1640995200000' could not be parsed at index 0
io.micronaut.serde.exceptions.SerdeException: Error decoding property [Date value] of type [class test.Test]: Text '1640995200000' could not be parsed at index 0
	at app//io.micronaut.serde.support.deserializers.DeserBean$DerProperty.deserializeAndSetPropertyValue(DeserBean.java:869)
	at app//io.micronaut.serde.support.deserializers.SimpleObjectDeserializer.deserializeInto(SimpleObjectDeserializer.java:100)
	at app//io.micronaut.serde.support.deserializers.SimpleObjectDeserializer.deserialize(SimpleObjectDeserializer.java:70)
	at app//io.micronaut.serde.support.deserializers.SimpleObjectDeserializer.deserializeNullable(SimpleObjectDeserializer.java:80)
	at app//io.micronaut.serde.support.deserializers.ErrorCatchingDeserializer.deserializeNullable(ErrorCatchingDeserializer.java:65)

Inconsistent Behavior

The same Json string input will be deserialized properly if the @JsonFormat(pattern = "yyyy-MM-dd@HH:mm:ss.SSSZ") removed since the FormattedTemporalSerde.deserialize() is missing the error handling when processing the annotated date field compared to DefaultFormattedTemporalSerde.deserialize() method.

[CLAassistant]

All committers have signed the CLA.

[dstepanov]

Can you please add the test to serde-jackson-tck to check if the behavior is the same as with Jackson Databind?

[jjhz]

@dstepanov test has been added into serde-jackson-tck

[dstepanov]

You can delete the other test

[jjhz]

@dstepanov test case removed from other module. Only added toserde-jackson-tck

[dstepanov]

Sorry, my suggestion was a bit incorrect. It looks like DatabindJsonFormatSpec is disabled.

I tried your test with Jackson, and it returned different results. Can you please align it as much as possible with Jackson Databind?

[dstepanov]

Some tests looks like need to add startsWith because of extra zeros

[jjhz]

Hi @dstepanov , sorry about the late reply.
I modified the test cases and changed the implementation slightly. Now the same test cases should work fine under the both serde-jackson-tck and serde-jackson. Let me know what you think. Thank you.

[jjhz]

@dstepanov The last build failed and now I merged the latest main into my branch. Do you mind to trigger another build?

[dstepanov]

I will review next week. Thanks!

[jjhz]

I will review next week. Thanks!

Thanks. Found few test failures regarding the timezone. Will fix them on weekend.

[jjhz]

@dstepanov Fixed few test cases. Do you mind to approve the build once more?

[dstepanov]

Thanks @jjhz !