Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always catch runtime exceptions from serializers and deserializers #879

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Always catch runtime exceptions from serializers and deserializers #879

merged 1 commit into from
Jun 25, 2024

Conversation

dstepanov
Copy link
Contributor

Fixes #878

@dstepanov dstepanov added the type: bug Something isn't working label Jun 25, 2024
@dstepanov dstepanov requested review from graemerocher and yawkat June 25, 2024 10:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
67.4% Coverage on New Code (required ≥ 70%)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

graemerocher
graemerocher approved these changes Jun 25, 2024
View reviewed changes
...upport/src/main/java/io/micronaut/serde/support/deserializers/ErrorCatchingDeserializer.java
* @author Denis Stepanov
*/
@Internal
class ErrorCatchingDeserializer<T> implements Deserializer<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s inherited

serde-support/src/main/java/io/micronaut/serde/support/serializers/ErrorCatchingSerializer.java
* @author Denis Stepanov
*/
@Internal
class ErrorCatchingSerializer<T> implements Serializer<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s inherited

@graemerocher graemerocher merged commit e6c2d31 into 2.10.x Jun 25, 2024
16 of 17 checks passed
@graemerocher graemerocher deleted the catchex branch June 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstepanov @graemerocher @yawkat