Improve Enum handling parity with Jackson #818
Conversation
|
|
...port/src/main/java/io/micronaut/serde/support/deserializers/collect/EnumMapDeserializer.java
Outdated
Show resolved
Hide resolved
...port/src/main/java/io/micronaut/serde/support/deserializers/collect/EnumMapDeserializer.java
Show resolved
Hide resolved
|
|
||
| @NonNull | ||
| private E transform(@NonNull Decoder decoder, Object value) throws IOException { | ||
| for (EnumBeanIntrospection.EnumConstant<? super E> enumConstant : enumIntrospection.getConstants()) { |
There was a problem hiding this comment.
Can you precalculate some of this stuff? Maybe create a map instead of interesting on every deserialization
There was a problem hiding this comment.
Added pre-calculation in 9d4e089
|
|
||
| @Override | ||
| public void serialize(@NonNull Encoder encoder, @NonNull EncoderContext context, @NonNull Argument<? extends E> type, E value) throws IOException { | ||
| for (EnumBeanIntrospection.EnumConstant<? extends E> enumConstant : enumIntrospection.getConstants()) { |
There was a problem hiding this comment.
Please try to precalculate constants as a map
There was a problem hiding this comment.
Added pre-calculation in 9d4e089
| public E deserialize(@NonNull Decoder decoder, @NonNull DecoderContext context, @NonNull Argument<? super E> type) throws IOException { | ||
| var value = decoder.decodeString(); | ||
|
|
||
| for (EnumBeanIntrospection.EnumConstant<? super E> enumConstant : enumIntrospection.getConstants()) { |
There was a problem hiding this comment.
Same here, please try to precalculate
There was a problem hiding this comment.
Added pre-calculation in 9d4e089
|
Please fix checkstyle |
|
I have refactored caching a bit, please check. |
|
I think, need add test, when you use @Serdeable
enum MyEnum {
VALUE1("value_1"),
VALUE2("value_2"),
VALUE3("value_3");
private final String value;
MyEnum(String value) {
this.value = value;
}
@JsonValue
public String getValue() {
return value;
}
} |
|
oh, It already exists. Then everything looks good to me |
|
Thanks @oujesky ! |
Improve Enum handling parity with Jackson (#818)
Improve Enum handling parity with Jackson (#818)
Improve enum serialization and deserialization to move closer to parity with Jackson
Additional Jackson annotations support:
@JsonValue@JsonPropertyImproved
EnumSetde/serialization of contained enumsAdded support for
EnumMap