Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for @JsonProperty annotation on enum constant level #757

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Add test for @JsonProperty annotation on enum constant level #757

merged 4 commits into from
Apr 25, 2024

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Feb 4, 2024

See: #503

@altro3
Copy link
Contributor Author

altro3 commented Feb 4, 2024

@dstepanov Added test for this case. All works fine with databind

@dstepanov
Copy link
Contributor

Please add this and other test as @PendingFeature so it can be merged

@altro3 altro3 force-pushed the json-property-on-enum-const branch 2 times, most recently from a52400c to f1b0a6a Compare February 5, 2024 15:03
@altro3 altro3 force-pushed the json-property-on-enum-const branch from f1b0a6a to 109c54a Compare February 5, 2024 15:06
@altro3
Copy link
Contributor Author

altro3 commented Feb 5, 2024

done

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dstepanov
Copy link
Contributor

Can you please rebase it and check if it's working?

@altro3 altro3 changed the base branch from 2.9.x to 2.10.x April 25, 2024 09:34
@altro3 altro3 force-pushed the json-property-on-enum-const branch from e0869f2 to 4453a16 Compare April 25, 2024 09:35
@altro3
Copy link
Contributor Author

altro3 commented Apr 25, 2024

Yes, now all works fine. Just close this PR or merge?

@dstepanov dstepanov merged commit 7934942 into micronaut-projects:2.10.x Apr 25, 2024
12 checks passed
@dstepanov
Copy link
Contributor

We can have extra test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altro3 @dstepanov @CLAassistant