Support @JsonIgnoreProperties(allowGetters,allowSetters), align with Jackson behaviour
#640
Conversation
…h Jackson behaviour
| @@ -687,6 +686,16 @@ private void visitSubtype(ClassElement supertype, ClassElement subtype, VisitorC | |||
| return; | |||
| } | |||
|
|
|||
| if (!subtype.hasAnnotation(SerdeConfig.SerIgnored.class)) { | |||
| // Replicate the Jackson behaviour of using the ignore annotation from supertype but allow to override it | |||
| AnnotationValue<SerdeConfig.SerIgnored> serIgnored = supertype.getAnnotation(SerdeConfig.SerIgnored.class); | |||
There was a problem hiding this comment.
what if it's on the supersupertype
There was a problem hiding this comment.
The annotation is not inherited
There was a problem hiding this comment.
in a hierarchy of A extends B and B extends C, and C has @SerIgnored, I think this will mean that A will only get SerIgnored if B is visited before A?
There was a problem hiding this comment.
No, @SerIgnored is not inherited, so adding it to B shouldn't add it to A.
There was a problem hiding this comment.
but youre copying it here? i dont understand what youre saying. this code copies the annotation from the supertype, but not if it's further up, even though i assume in jackson it would still be considered for such a hierarchy
There was a problem hiding this comment.
The subtypes in this code are the subtypes of the base class defined by JsonSubTypes. The logic is called one. It’s not called on every type.
There was a problem hiding this comment.
ohhhh i see. does that match jackson though? my guess is that with jackson, the property is considered part of the parent class because the parent class defines a getter of that name, so JsonIgnoreProperties is considered even though it's not technically @Inherited. I doubt this behavior is specific to JsonSubTypes.
There was a problem hiding this comment.
The ignore is not inherited. With subtypes it acts the same, if you put ignore again and want to ignore something from the supertype you need to repeat it.
There was a problem hiding this comment.
ive pushed a pendingfeature with the setup that i mean. the test passes with jackson-databind.
There was a problem hiding this comment.
Ahh, looks like Jackson respects the last definition. I can take a look in the next PR
serde-support/src/main/java/io/micronaut/serde/support/deserializers/DemuxingObjectDecoder.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
Fixes #581
Fixes #550