-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unwrapped subtype beans #624
Conversation
SonarCloud Quality Gate failed. 0 Bugs 78.3% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
* @since 2.3 | ||
*/ | ||
@Indexed(ObjectSerializer.class) | ||
public interface ObjectSerializer<T> extends Serializer<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is a confusing name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you suggest? Before I had SerializerInto
but I think it makes more sense to call it ObjectSerializer
because serializeInto
can only be used with a serializer representing JSON objects {...}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnwrappedObjectSerializer maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that an object serializer is any serializer representing an object, and if you put the unwrapped annotation, it will use serializeInto
method to avoid creating an outer object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge it, and rename it later if you have a better suggestion
Fixes #263