Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 299 #300

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Fix for 299 #300

merged 3 commits into from
Nov 2, 2022

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Nov 1, 2022

see: #299

@sdelamo sdelamo changed the base branch from master to 1.3.x November 1, 2022 14:37
@sdelamo sdelamo linked an issue Nov 1, 2022 that may be closed by this pull request
JsonAnyGetter does not work for for Serde but works for Jackson #299
Closed
@dstepanov dstepanov changed the title test: test for 299 Fix for 299 Nov 2, 2022
graemerocher
graemerocher requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@graemerocher graemerocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you modify this PR to not need the http server? It seems unnecessary to include it

@graemerocher graemerocher mentioned this pull request Nov 2, 2022
Closed
@sdelamo
Copy link
Contributor Author

sdelamo commented Nov 2, 2022

can you modify this PR to not need the http server? It seems unnecessary to include it

I have removed the server. Now:

  • ✅ Pojo with @Serdable and serde
  • ✅ Pojo without annotations and jackson
  • ❌ Pojo with @introspected and jackson

@sdelamo sdelamo requested a review from graemerocher November 2, 2022 15:24
@graemerocher graemerocher merged commit 703756a into 1.3.x Nov 2, 2022
@graemerocher graemerocher deleted the issue-299 branch November 2, 2022 15:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees

@dstepanov dstepanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JsonAnyGetter does not work for for Serde but works for Jackson
3 participants
@sdelamo @graemerocher @dstepanov