Fix JacksonDecoder depth handling (#559)

Fixes #557
micronaut-projects · Sep 1, 2023 · 4eb5a7f · 4eb5a7f
1 parent bbf614a
commit 4eb5a7f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/serde-jackson/src/main/java/io/micronaut/serde/jackson/JacksonDecoder.java b/serde-jackson/src/main/java/io/micronaut/serde/jackson/JacksonDecoder.java
@@ -120,6 +120,7 @@ public void finishStructure() throws IOException {
         if (token != JsonToken.END_ARRAY && token != JsonToken.END_OBJECT) {
             throw new IllegalStateException("Not all elements have been consumed yet");
         }
+        decreaseDepth();
     }
 
     @Override

diff --git a/serde-jackson/src/test/groovy/io/micronaut/serde/jackson/JacksonDecoderSpec.groovy b/serde-jackson/src/test/groovy/io/micronaut/serde/jackson/JacksonDecoderSpec.groovy
@@ -132,4 +132,18 @@ class JacksonDecoderSpec extends Specification {
         then:
         thrown SerdeException
     }
+
+    def "long array"() {
+        when:
+        def len = 5000
+        def json = '[' + "{},".repeat(len - 1) + '{}]'
+        def decoder = createDecoder(json)
+        def arrayDecoder = decoder.decodeArray()
+        then:
+        for (int i = 0; i < len; i++) {
+            arrayDecoder.decodeObject().finishStructure()
+        }
+        !arrayDecoder.hasNextArrayValue()
+        arrayDecoder.finishStructure()
+    }
 }