Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: changes to support OpenID Connect RP-Initiated Logout 1.0 + Keycloak 17/18+ #1049

Draft
wants to merge 3 commits into
base: 5.0.x
Choose a base branch
from

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Jun 30, 2022

see: https://openid.net/specs/openid-connect-rpinitiated-1_0.html

closes Issue #1045

This is a work in progress and not necessarily a correct solution.

@wetted wetted requested a review from sdelamo June 30, 2022 15:11
@wetted
Copy link
Contributor Author

wetted commented Jun 30, 2022

I just started getting a build error locally. I'm not sure yet what's going on. I am on vacation until 5 July, so I won't look at it before then.


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':security-oauth2:japiCmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
   > Detected binary changes.
         - current: security-oauth2-3.6.2-SNAPSHOT.jar
         - baseline: micronaut-security-oauth2-3.6.1.jar.

@wetted wetted changed the title WIP: changes to support OpenID Connect RP-Initiated Logout 1.0 WIP: changes to support OpenID Connect RP-Initiated Logout 1.0 + Keycloak 17/18+ Jul 11, 2022
@wetted wetted requested a review from timyates July 11, 2022 21:57
@wetted
Copy link
Contributor Author

wetted commented Jul 11, 2022

I've made some progress. I'm down to three test failures, but the Keycloak 18 support still needs work.

Note that testcontainers-keycloak requires Java 11+ so the tests that use the Keycloak.groovy test util class are disabled for Java 8.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.9% 83.9% Coverage
0.0% 0.0% Duplication

@timyates
Copy link
Contributor

Did some things on the Keycloak 18 side over here #1053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants