Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct generating no vars classes #1799

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Sep 30, 2024

No description provided.

@altro3
Copy link
Collaborator Author

altro3 commented Sep 30, 2024

Don't know how to create schema class without properites... But it possibly with kotlin noargs plugin. See details here: OpenAPITools/openapi-generator#14710

@altro3 altro3 requested a review from sdelamo September 30, 2024 15:34
@altro3 altro3 force-pushed the correct-process-novars branch from 62f0ae0 to 26d84fe Compare September 30, 2024 15:41
@altro3 altro3 requested a review from graemerocher October 3, 2024 06:46
sdelamo
sdelamo previously requested changes Oct 4, 2024
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

@altro3
Copy link
Collaborator Author

altro3 commented Oct 4, 2024

The problem is that I can't figure out in which case a class without attributes is generated. But it is definitely possible, since there is an issue. I checked it locally by forcing noArgs = true into the calculations

@altro3 altro3 force-pushed the correct-process-novars branch from 26d84fe to 145f842 Compare October 6, 2024 10:50
@altro3
Copy link
Collaborator Author

altro3 commented Oct 6, 2024

@sdelamo Tests added

@altro3 altro3 requested a review from sdelamo October 7, 2024 11:06
@graemerocher
Copy link
Contributor

Please resolve conflicts

@altro3 altro3 force-pushed the correct-process-novars branch 2 times, most recently from dc92e4f to de56711 Compare October 10, 2024 08:17
@altro3
Copy link
Collaborator Author

altro3 commented Oct 10, 2024

@graemerocher done

@altro3 altro3 force-pushed the correct-process-novars branch 2 times, most recently from e09aa02 to 9049d6e Compare October 10, 2024 10:57
@altro3 altro3 force-pushed the correct-process-novars branch from 9049d6e to f97b929 Compare October 10, 2024 11:01
@altro3 altro3 dismissed sdelamo’s stale review October 10, 2024 11:23

fixed. Need to merge it

@altro3 altro3 merged commit 03c82f6 into micronaut-projects:6.13.x Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants