Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tenantId via EL with new annotation module #255

Merged
merged 13 commits into from
Nov 22, 2023
Merged

Conversation

timyates
Copy link
Contributor

This PR adds a new ExpressionEvaluationContext which allows us to use tenantId in EL expressions.

Added test-suite in all 3 languages to allow documenting it's usage and validating the docs source

Closes #248

This PR adds a new ExpressionEvaluationContext which allows us to use tenantId in EL expressions.

Added test-suite in all 3 languages to allow documenting it's usage and validating the docs source
@timyates timyates added the type: enhancement New feature or request label Nov 21, 2023
@timyates timyates added this to the 5.2.0 milestone Nov 21, 2023
@timyates timyates requested a review from sdelamo November 21, 2023 15:41
@timyates timyates self-assigned this Nov 21, 2023
src/main/docs/guide/multitenancy/tenantexpression.adoc Outdated Show resolved Hide resolved
src/main/docs/guide/multitenancy/tenantexpression.adoc Outdated Show resolved Hide resolved
test-suite-groovy/build.gradle.kts Outdated Show resolved Hide resolved

testRuntimeOnly(mn.snakeyaml)
testRuntimeOnly(mnLogging.logback.classic)
testRuntimeOnly(libs.junit.jupiter.engine)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this dependency.

Suggested change
testRuntimeOnly(libs.junit.jupiter.engine)

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.5% 61.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sdelamo sdelamo merged commit af4c864 into master Nov 22, 2023
10 of 11 checks passed
@sdelamo sdelamo deleted the tenantid-el branch November 22, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support Expression Language for Tenant resolution
2 participants