#144 integrate with HiveMQ client feature complete #298
Conversation
* Update common files * Removed 'check' task dependency on 'nativeTest' task --------- Co-authored-by: Milenko Supic <supic82@gmail.com>
….4 (micronaut-projects#260) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….6.0 (micronaut-projects#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ronaut-projects#261) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…icronaut-projects#258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lvm.buildtools.native.gradle.plugin to v0.9.22 (micronaut-projects#259) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…o v2.0.0-m8 (micronaut-projects#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ources-plugin to v4.0.0-m3 (micronaut-projects#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lugin to v4.0.0-m3 (micronaut-projects#266) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0-m5 (micronaut-projects#275) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…tion-bom to v4.0.0-m8 (micronaut-projects#274) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ources-plugin to v4.0.0-m4 (micronaut-projects#273) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…om to v3.0.0-m5 (micronaut-projects#283) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…om to v1.0.0-m3 (micronaut-projects#282) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…o v2.0.0-m9 (micronaut-projects#285) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…om to v3.0.0-m6 (micronaut-projects#288) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lvm.buildtools.native.gradle.plugin to v0.9.23 (micronaut-projects#293) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….7.0 (micronaut-projects#290) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rm to v4.0.0-m4 (micronaut-projects#292) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…om to v1.0.0-m5 (micronaut-projects#295) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mqtt-hivemq/src/main/java/io/micronaut/mqtt/hivemq/v3/client/Mqtt3ClientAdapter.java
Show resolved
Hide resolved
mqtt-hivemq/src/main/java/io/micronaut/mqtt/hivemq/v3/client/Mqtt3ClientAdapter.java
Show resolved
Hide resolved
mqtt-hivemq/src/main/java/io/micronaut/mqtt/hivemq/v3/client/Mqtt3ClientAdapter.java
Outdated
Show resolved
Hide resolved
mqtt-hivemq/src/main/java/io/micronaut/mqtt/hivemq/v5/client/Mqtt5ClientAdapter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is awesome 👍
We have a slight issue whereby the configuration reference is not created for the hivemq v5 configuration, and I'm currently not sure why
Once we have that, we should include the v3 and v5 config into the guide as we do for the other clients
But I see no reason why that should block this being merged
Thanks @skobow !
Over to you @sdelamo
|
Ahhh @sdelamo I think I worked out why we don't see both config objects in the configuration reference. I think it's because both of them have the same prefix, and they are both in the same module... I think we key off the prefix on a per-module basis... I'll work on a fix once I work out where it comes from 😉 |
|
@skobow are ok you of us merging this PR into the base branch and review adjusting the other PR? |
|
@timyates anything I can assist with? My goal was that v3 and v5 could possibly use the same configuration. Of course there are some differences but non should be conflicting. But maybe I just didn't get the issue right. |
|
@skobow No, we should be fine... Our annotation processor that generates docs didn't expect multiple configurations in the same module with the same prefix... We can take it from here :-) |
Integration of HiveMQ MQTT client feature complete with running tests. Configuration will be changed and adopted to HiveMQ client. Documentation missing.