Add GraalVM Native Image and Truffle compilation sections for GraalPy guides #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olyagpl
suggested changes
Dec 12, 2024
guides/micronaut-graalpy-python-package/micronaut-graalpy-python-package.adoc
Outdated
Show resolved
Hide resolved
|
@steve-s, I joined as a reviewer, left comments, but can't tell why this guide is broken. Sergio should know better. |
|
@steve-s, could you please, in your PR, remove this extra 1 in the NI Maven plugin code snippet: |
Co-authored-by: Olga Gupalo <olga.gupalo@oracle.com>
olyagpl
reviewed
Dec 18, 2024
olyagpl
approved these changes
Dec 18, 2024
|
@sdelamo can you please take a look and eventually merge |
olyagpl
approved these changes
Dec 18, 2024
olyagpl
reviewed
Dec 18, 2024
| @@ -64,7 +64,7 @@ It is possible to customize the name of the native executable or pass additional | |||
| <version>0.10.3</version> | |||
| <configuration> | |||
| <!-- <1> --> | |||
| <imageName>mn-graalvm-application</imageName> <1> | |||
| <imageName>mn-graalvm-application</imageName> | |||
|
ping :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From GraalVM JDK 23, Micronaut apps with GraalPy can be also compiled with GraalVM Native Image.
We also noticed that this guide is broken for some reason: https://guides.micronaut.io/latest/micronaut-graalpy-python-package.html. Any ideas why that could be?