Re-enable Maven tests after 4.3.6 release #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
approved these changes
Mar 15, 2024
|
EclipseStore kotlin now 😢 |
timyates
referenced
this pull request
in micronaut-projects/micronaut-serialization
Mar 18, 2024
There is an issue in 2.8.2 when serializing an empty string to a non-null field in Kotlin. This works in 2.8.1, and was exposed by the eclipsestore guide https://github.com/micronaut-projects/micronaut-guides/pull/1443\#commits-pushed-0276ab1
|
Because the fix for this isn't until Micronaut 4.4.0 |
|
✅ |
sdelamo
approved these changes
Mar 18, 2024
AndreaLaGrotteria
pushed a commit
to AndreaLaGrotteria/micronaut-guides
that referenced
this pull request
Oct 3, 2024
* Disable Kotlin Microstream/EclipseStore guide due to micronaut-projects/micronaut-serialization#794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once 4.3.6 is out with micronaut-projects/micronaut-core#10597 we should be able to merge this to re-enable the maven tests for the 3 guides that had issues