Run tests with Java 21 #1362
Merged
Run tests with Java 21 #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the matrix to run PRs and the SNAPSHOT tests on Java 17 AND 21 Leave publishing on Java 17
We need this as we need to pick up Kapt add-opens. If we use the daemon, then these are not picked up and kapt compilations will fail
sdelamo
requested changes
Nov 3, 2023
| import jakarta.inject.Singleton; | ||
|
|
||
| @Singleton | ||
| public class MockServerClient implements Feature { |
There was a problem hiding this comment.
It collides with the one in v4.2.0 of Micronaut Starter
I assume this was added as a stop-gap until we got to use the one in 4.2.0?
# Conflicts: # buildSrc/src/main/resources/pom.xml # version.txt
sdelamo
approved these changes
Nov 17, 2023
|
@sdelamo should we switch to just testing 21 on a nightly basis? |
yup. great job making the java 21 transition |
AndreaLaGrotteria
pushed a commit
to AndreaLaGrotteria/micronaut-guides
that referenced
this pull request
Oct 3, 2024
* Run tests with Java 21 Update the matrix to run PRs and the SNAPSHOT tests on Java 17 AND 21 Leave publishing on Java 17 * Gradle 8.4 * WIP * Limit Guides to 17 where sensible * Fix micronaut-graalvm-reflection validation * If running on Java 21, don't use the Gradle daemon We need this as we need to pick up Kapt add-opens. If we use the daemon, then these are not picked up and kapt compilations will fail * Limit google-function guide to java 17 * Kill the kotlin compilation daemon before and after kapt tests * Few more Java 21 exclusions for Lambda * Remove non-required changes * Add debug * Remove debug, use a loop * Re-enable conditional * Another 21 exclusion * Stop downgrading Kotlin to Java 17 for Spring/Kotlin apps --------- Co-authored-by: sdelamo <sergio.delamo@softamo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once starter is released for 4.2.0 and we can generate Java 21 projects, this can be merged
Currently it is set up to use 4.2.0-SNAPSHOT as the version target.
Excluded lambda and function guides which only work on 17.
There is one odd change that was required. When running Kapt projects, we needed to kill the Kotlin Compile Daemon as it holds on to the old properties it was started with, and doesn't notice that it needs to update to include the
--add-opensfor Kapt to work.--stopthe gradle daemons (as this would kill the build itself)--no-daemonfor all the builds as it takes AGES to run all the tests--no-daemonon just the kapt builds, as the Gradle daemon finds the old Kotlin daemon.So I went with
find the kotlin daemon and kill itbefore and after Kapt builds