build: Micronaut Framework to 3.8.3 #1231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We released a release called v3.6.5 so the regular expression needed to change in the tests 2. We were not testing the regular client which does streaming, both tests tested the low level client despite their names
|
@sdelamo 🎉 |
sdelamo
commented
Feb 2, 2023
timyates
reviewed
Feb 2, 2023
Comment on lines
-59
to
-64
| NOTE: Instead of `retrieve` we could have used `jsonStream`. You can use `jsonStream()` to stream arrays of type `application/json` or | ||
| JSON streams of type `application/x-json-stream`. If we use `retrieve`, such as in the previous code listing, the operation will not block. | ||
| However, it will not return until all the data has been received from the server. In the case of a JSON array that would be the whole array. | ||
| However, if you are interested in just the first element of the array, `jsonStream` provides a better alternative since it starts streaming data from the server without needing the whole response. | ||
| For example, `jsonStream().firstElement()` will only parse the first item in a JSON array. Hence it is more efficient. | ||
|
|
There was a problem hiding this comment.
I removed this, as jsonStream is not a method of HttpClient and I considered it too complex for this guide to start talking about the StreamingHttpClient at this point in the docs
|
As discussed, I split out another test which tests the JSON stream endpoint using the StreamingHttpClient |
|
I ported your StreamingHttpClient test here: #1236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.