Support for GCP PubSub Push Subscriptions #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got to make some minor changes to one of the tests because it keeps failing (only) in CI, but this is otherwise ready for review. |
sdelamo
requested changes
Jan 8, 2024
|
Should probably bump the version to 5.4.0-SNAPSHOT in gradle.properties (as these changes are for 5.4.0) |
timyates
suggested changes
Jan 9, 2024
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/intercept/PubSubPushConsumerAdvice.java
Outdated
Show resolved
Hide resolved
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/push/PushController.java
Outdated
Show resolved
Hide resolved
gcp-pubsub/src/test/groovy/io/micronaut/gcp/pubsub/bind/PubSubPushSpec.groovy
Show resolved
Hide resolved
gcp-pubsub/src/test/groovy/io/micronaut/gcp/pubsub/bind/PubSubPushSpec.groovy
Show resolved
Hide resolved
gcp-pubsub/src/test/groovy/io/micronaut/gcp/pubsub/bind/PubSubPushSpec.groovy
Show resolved
Hide resolved
gcp-pubsub/src/test/groovy/io/micronaut/gcp/pubsub/bind/PubSubPushSpec.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Yates <tim.yates@gmail.com>
timyates
approved these changes
Jan 10, 2024
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/annotation/PushSubscription.java
Show resolved
Hide resolved
Co-authored-by: Tim Yates <tim.yates@gmail.com>
- Replace writeValueAsString#getBytes with writeValueAsBytes - Inject JsonMapper instead of JsonMapper.createDefault()
sdelamo
approved these changes
Jan 25, 2024
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/validation/PushMessageValidator.java
Outdated
Show resolved
Hide resolved
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/push/PushSubscriberHandler.java
Outdated
Show resolved
Hide resolved
|
@graemerocher @dstepanov please check this PR and see if you are ok with the usage of We played with this idea in security but we went a different direction. |
graemerocher
approved these changes
Jan 25, 2024
dstepanov
requested changes
Jan 25, 2024
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/validation/PushMessageValidator.java
Show resolved
Hide resolved
...b/src/main/java/io/micronaut/gcp/pubsub/intercept/AbstractPubSubConsumerMethodProcessor.java
Outdated
Show resolved
Hide resolved
gcp-pubsub/src/main/java/io/micronaut/gcp/pubsub/push/DefaultPushSubscriberHandler.java
Outdated
Show resolved
Hide resolved
|
sdelamo
approved these changes
Jan 26, 2024
dstepanov
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support is added for GCP PubSub Push subscriptions.
Push subscription messages may be handled by methods annotated with the new
@PushSubscriptionannotation.Push messages are sent to the application via HTTP request from the PubSub service.
Beyond the different infrastructure used to ingest the messages, care has been taken to keep the semantics of
@Subscriptionand@PushSubscriptionmethods nearly identical.Closes #946