Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the supplied contact name in SesEmailComposer #127

Closed
wants to merge 22 commits into from
Closed

Use the supplied contact name in SesEmailComposer #127

wants to merge 22 commits into from

Conversation

mvelez-nydig
Copy link
Contributor

@mvelez-nydig mvelez-nydig commented Sep 21, 2022 •
edited
Loading

Possible fix for #117

renovate bot and others added 6 commits September 8, 2022 10:40
mvelez-nydig and others added 13 commits September 21, 2022 16:19
@mvelez-nydig
address comments
47d052e
@sdelamo
Merge branch '1.3.x'
75b4950
@renovate
fix(deps): update dependency org.jetbrains.kotlin:kotlin-stdlib-jdk8 …
d7893ab 
…to v1.7.20 (micronaut-projects#133)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update plugin org.jetbrains.kotlin.kapt to v1.7.20 (micr…
d7efcb5 
…onaut-projects#132)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update peter-evans/create-pull-request action to v4.1.3 (m…
bbd1714 
…icronaut-projects#128)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update stefanzweifel/git-auto-commit-action action to v4…
317b0be 
….15.0 (micronaut-projects#129)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update mikepenz/action-junit-report action to v3.5.1 (mi…
a71cb37 
…cronaut-projects#124)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency io.micronaut:micronaut-bom to v3.7.1 (mi…
83edb18 
…cronaut-projects#121)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @sdelamo
chore(deps): update plugin org.jetbrains.kotlin.jvm to v1.7.20 (micro…
b6be430 
…naut-projects#131)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@renovate
fix(deps): update dependency org.apache.poi:poi-ooxml to v5.2.3 (micr…
0656cb7 
…onaut-projects#125)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@sdelamo
Merge branch '2.0.x'
23bfc64
@micronaut-build @sdelamo
ci: SLSA provenance (micronaut-projects#112)
4283d54 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted
build: io.micronaut.build.shared.settings to 6.0.0 (micronaut-project…
3631604 
…s#130)

* ci for java 17 only
sdelamo
sdelamo requested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, the base branch of this PR should be 1.4.x. Can you change it?

email-amazon-ses/src/main/java/io/micronaut/email/ses/SesEmailComposer.java Outdated Show resolved Hide resolved
email-amazon-ses/src/main/java/io/micronaut/email/ses/SesEmailComposer.java Outdated Show resolved Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy Outdated Show resolved Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy Outdated Show resolved Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy Outdated Show resolved Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy Outdated Show resolved Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy Outdated Show resolved Hide resolved
@mvelez-nydig mvelez-nydig changed the base branch from master to 1.4.x October 3, 2022 15:11
@mvelez-nydig
Copy link
Contributor Author

mvelez-nydig commented Oct 3, 2022 •
edited
Loading

Please, the base branch of this PR should be 1.4.x. Can you change it?

@sdelamo changed the base branch and addressed your comments. Let me know if these look right.
EDIT: changing the base branch in the PR resulted in a bunch of changes that I'm not sure if we want to replicate for branch 1.4.x. Can re-fork from that branch and create a new PR if needed

@velezclef velezclef mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmostowich-nydig nmostowich-nydig nmostowich-nydig left review comments

@sdelamo sdelamo sdelamo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mvelez-nydig @sdelamo @nmostowich-nydig @wetted @micronaut-build