-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log debug instead of warn when introspected entity cannot be mapped and falls back to mongo deserialize #3261
Open
radovanradic
wants to merge
2
commits into
4.10.x
Choose a base branch
from
mongo-dto
base: 4.10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
data-mongodb/src/test/java/io/micronaut/data/document/mongodb/entities/ChangeLog.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
package io.micronaut.data.document.mongodb.entities; | ||
|
||
public record ChangeLog(String message) { | ||
} |
60 changes: 60 additions & 0 deletions
60
data-mongodb/src/test/java/io/micronaut/data/document/mongodb/entities/Customer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
package io.micronaut.data.document.mongodb.entities; | ||
|
||
import io.micronaut.data.annotation.GeneratedValue; | ||
import io.micronaut.data.annotation.Id; | ||
import io.micronaut.data.annotation.MappedEntity; | ||
|
||
import java.util.List; | ||
|
||
@MappedEntity | ||
public final class Customer { | ||
@Id | ||
@GeneratedValue | ||
private String id; | ||
private String firstName; | ||
private String lastName; | ||
|
||
private List<ChangeLog> changeLogs; | ||
|
||
public Customer() { | ||
} | ||
|
||
public Customer(String id, String firstName, String lastName, List<ChangeLog> changeLogs) { | ||
this.id = id; | ||
this.firstName = firstName; | ||
this.lastName = lastName; | ||
this.changeLogs = changeLogs; | ||
} | ||
|
||
public String getId() { | ||
return id; | ||
} | ||
|
||
public void setId(String id) { | ||
this.id = id; | ||
} | ||
|
||
public String getFirstName() { | ||
return firstName; | ||
} | ||
|
||
public void setFirstName(String firstName) { | ||
this.firstName = firstName; | ||
} | ||
|
||
public String getLastName() { | ||
return lastName; | ||
} | ||
|
||
public void setLastName(String lastName) { | ||
this.lastName = lastName; | ||
} | ||
|
||
public List<ChangeLog> getChangeLogs() { | ||
return changeLogs; | ||
} | ||
|
||
public void setChangeLogs(List<ChangeLog> changeLogs) { | ||
this.changeLogs = changeLogs; | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
data-mongodb/src/test/java/io/micronaut/data/document/mongodb/entities/CustomerView.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package io.micronaut.data.document.mongodb.entities; | ||
|
||
import io.micronaut.core.annotation.Introspected; | ||
import org.bson.codecs.pojo.annotations.BsonId; | ||
import org.bson.codecs.pojo.annotations.BsonRepresentation; | ||
|
||
import static org.bson.BsonType.OBJECT_ID; | ||
|
||
@Introspected | ||
public record CustomerView(@BsonId @BsonRepresentation(OBJECT_ID) String id, String firstName, String lastName) { | ||
} |
16 changes: 16 additions & 0 deletions
16
...odb/src/test/java/io/micronaut/data/document/mongodb/repositories/CustomerRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package io.micronaut.data.document.mongodb.repositories; | ||
|
||
import io.micronaut.data.document.mongodb.entities.Customer; | ||
import io.micronaut.data.document.mongodb.entities.CustomerView; | ||
import io.micronaut.data.mongodb.annotation.MongoFindQuery; | ||
import io.micronaut.data.mongodb.annotation.MongoRepository; | ||
import io.micronaut.data.repository.CrudRepository; | ||
|
||
import java.util.List; | ||
|
||
@MongoRepository | ||
public interface CustomerRepository extends CrudRepository<Customer, String> { | ||
|
||
@MongoFindQuery(filter = "{}", project = "{ changeLogs: 0}") | ||
List<CustomerView> viewFindAll(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens here is we get this map
which cannot be deserialized to the record
because
_id
andid
are mismatched in introspected mapper. Therefore we catch exception and fallback to this code